Add integration tests for CLI-to-socket communication#17
Open
cv wants to merge 42 commits intonicobailon:mainfrom
Open
Add integration tests for CLI-to-socket communication#17cv wants to merge 42 commits intonicobailon:mainfrom
cv wants to merge 42 commits intonicobailon:mainfrom
Conversation
…ke, console, network - Tab group commands: tab.group, tab.ungroup, tab.groups - Wait base command with duration - Upload with ref and files - Resize with dimensions - Smoke with urls array and routes/fail-fast - Console base command with limit and clear options - Network base command with various filters (origin, method, status, format, verbose) - Updated assertion to use toEqual() for array comparisons
- Add @types/node dependency - Add 'node' to tsconfig types - Add explicit types for socket, chunk, code parameters - Use fileURLToPath for ESM-compatible __dirname
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive integration tests for the CLI-to-socket communication layer, addressing issue #6.
Changes
test/integration/cli-socket.test.tsit.each()for maintainabilityTest Coverage
Commands tested:
navigate,back,forwardgo→navigate,snap→screenshot,read→page.read,net→network,find→searche5), coordinates, selectorstype,key,hover,dragscroll,scroll.top,scroll.bottom,scroll.to,scroll.infopage.read,page.text,page.statetab.list,tab.new,tab.switch,tab.close,tab.name,tab.reload,tab.named,tab.unnamewindow.new,window.list,window.focus,window.close,window.resizewait.element,wait.url,wait.network,wait.load,wait.domlocate.role,locate.text,locate.labelnetwork.get,network.body,network.clear,network.stats,network.origins,network.curldialog.accept,dialog.dismiss,dialog.infocookie.list,cookie.get,cookie.set,cookie.clearframe.list,frame.switch,frame.main,frame.jsemulate.network,emulate.device,emulate.cpu,emulate.viewport,emulate.touch,emulate.geohistory.list,history.search,bookmark.list,bookmark.add,bookmark.removejs,form.fill,search,perf.metrics,perf.start,perf.stop,health,zoom--tab-id,--window-idError handling:
Test Results
Notes
/tmp/surf.sockto avoid breaking running surf instancesconsole,networkbase) read from local files and are excluded from socket testsCloses #6