Conversation
nickthegroot
left a comment
nickthegroot
left a comment
There was a problem hiding this comment.
Thanks for the PR! I had no clue getting the track URL was supported. There's a few changes I'd like to have before merging, but once they get done I can push up a new version with these changes.
| `${this._track.title} - ${this._track.artist} \n ${gMusicResult.value}`, | ||
| 'Copy URL to clipboard' | ||
| ) | ||
| .then(() => { |
There was a problem hiding this comment.
This still copys the URL even if the user clicks (X).
Instead of requesting user input, just copy the URL to the clipboard then let the user know the operation was successful.
| case 'time': | ||
| break | ||
| default: | ||
| console.log(gMusicChannel.channel) |
There was a problem hiding this comment.
There's not a lot of reason to log unsupported channels without context... it adds unnecessary clutter to the console. Let's take it out.
| let skipCommand = commands.registerCommand('gmusic.skip', () => { | ||
| gMusic.forward() | ||
| }) | ||
|
|
There was a problem hiding this comment.
Let's keep the line breaks consistant. For commands, I'd like to keep them without.
| }, | ||
| { | ||
| "command": "gmusic.getTrackURL", | ||
| "title": "Get Current Track URL", |
There was a problem hiding this comment.
If we're changing the command to not require interacting with the information box, let's change the title to Copy Track URL to Clipboard.
|
I will have a look at fixing this up when i get a chance! Yea you can actually call any function inside gmusic.js or gmusic-ui.js. I was originally trying to add a feature to add the current playing song to a playlist, but gmusic-ui currently lacks the functionality. |
2 participants
No description provided.