feat: Add continuous play functionality using watch playlists#322
Open
Gorrick wants to merge 1 commit intonick42d:mainfrom
Open
feat: Add continuous play functionality using watch playlists#322Gorrick wants to merge 1 commit intonick42d:mainfrom
Gorrick wants to merge 1 commit intonick42d:mainfrom
Conversation
nick42d
requested changes
Dec 30, 2025
Owner
There was a problem hiding this comment.
Awesome work grokking the codebase and submitting the PR.
No concerns on code quality or style, however a couple of requests:
- Please remove global visibility from the default keybind - global header is always going to be at risk of over crowding, and I think long-term I'd prefer to see the status of this feature on the footer or inside the playlist (PR welcome for this in the future)
- Please add basic unit test(s) to
playlist/tests.rs. I am currently improving the effect system and tests for playlist in #323 and so anything you can do to capture expected behaviour will help me avoid breakage.
Other than that the only blocker from my side is taking the time to test this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.