Skip to content

Fix flashcard visibility regression on mobile #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicholaspsmith merged 1 commit into from
Jan 14, 2026
Merged

Fix flashcard visibility regression on mobile #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions components/quiz/QuizCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ export default function QuizCard({ flashcard, onRate, onDelete }: QuizCardProps)
<div className={`flip-card-inner ${isAnswerRevealed ? 'flipped' : ''}`}>
{/* Front Face - Question Only */}
<div className="flip-card-front">
<div className="flex flex-col items-center justify-center min-h-[300px] sm:min-h-[400px] max-h-[70vh] p-4 sm:p-6 md:p-8 bg-white dark:bg-gray-800 rounded-lg shadow-lg overflow-y-auto">
<div className="flex flex-col items-center justify-center min-h-[300px] sm:min-h-[400px] p-4 sm:p-6 md:p-8 bg-white dark:bg-gray-800 rounded-lg shadow-lg overflow-y-auto">
{/* Question Section */}
<div className="w-full max-w-2xl mb-6 sm:mb-8 flex-1 min-h-0 overflow-y-auto">
<div className="w-full max-w-2xl mb-6 sm:mb-8">
<h2
id="flashcard-question-label"
className="text-xs sm:text-sm font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide mb-2"
Expand Down Expand Up @@ -143,9 +143,9 @@ export default function QuizCard({ flashcard, onRate, onDelete }: QuizCardProps)

{/* Back Face - Question + Answer + Rating */}
<div className="flip-card-back">
<div className="flex flex-col items-center justify-center min-h-[300px] sm:min-h-[400px] max-h-[70vh] p-4 sm:p-6 md:p-8 bg-white dark:bg-gray-800 rounded-lg shadow-lg overflow-y-auto">
<div className="flex flex-col items-center justify-center min-h-[300px] sm:min-h-[400px] p-4 sm:p-6 md:p-8 bg-white dark:bg-gray-800 rounded-lg shadow-lg overflow-y-auto">
{/* Question (for context) */}
<div className="w-full max-w-2xl mb-6 sm:mb-8 flex-1 min-h-0 overflow-y-auto">
<div className="w-full max-w-2xl mb-6 sm:mb-8">
<h2 className="text-xs sm:text-sm font-semibold text-gray-500 dark:text-gray-400 uppercase tracking-wide mb-2">
Question
</h2>
Expand All @@ -156,7 +156,7 @@ export default function QuizCard({ flashcard, onRate, onDelete }: QuizCardProps)

{/* Answer Section */}
<div
className="w-full max-w-2xl mb-6 sm:mb-8 pt-6 sm:pt-8 border-t border-gray-200 dark:border-gray-700 flex-1 min-h-0 overflow-y-auto"
className="w-full max-w-2xl mb-6 sm:mb-8 pt-6 sm:pt-8 border-t border-gray-200 dark:border-gray-700"
role="region"
aria-live="polite"
>
Expand Down
2 changes: 1 addition & 1 deletion components/study/FlashcardMode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export default function FlashcardMode({
{/* Card - T005: Perspective wrapper with key to reset on card change */}
<div
key={cardNumber}
className="w-full max-w-2xl min-h-[250px] sm:min-h-[300px] max-h-[70vh] [perspective:1000px]"
className="w-full max-w-2xl h-[250px] sm:h-[300px] [perspective:1000px]"
data-testid="flashcard"
>
{/* T006: 3D flip animation with transform-style and rotateY */}
Expand Down
Loading