Skip to content

Conversation

@vnktshr21
Copy link
Contributor

@vnktshr21 vnktshr21 commented Dec 17, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
    • Not updating since this is an internal change
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Added new attribute classes for
    • Comma separated string, but exposed in python API as list of strings
    • Time interval in months, but exposed in python API as hightime.timedelta
  • Added new nifake attributes for these classes and unit tests validating their behavior
  • Added converters for
    • list of strings to comma separated string
    • timedelta to months
      • Using the same 365/12=30.4167 conversion that was used previously
      • This is to cater to our C API returning interval values in months and us standardizing on using hightime.timedelta type for intervals in python API
  • Converters for the opposite side were already implemented
  • Added tests for newly added converters

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Build passes.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.10%. Comparing base (ee4860e) to head (684db26).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
+ Coverage   90.08%   90.10%   +0.01%     
==========================================
  Files          71       71              
  Lines       18644    18662      +18     
==========================================
+ Hits        16796    16815      +19     
+ Misses       1848     1847       -1     
Flag Coverage Δ
codegenunittests 84.44% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.72% <100.00%> (+0.20%) ⬆️
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 82.43% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nifake/nifake/_attributes.py 96.62% <100.00%> (+0.42%) ⬆️
generated/nifake/nifake/_converters.py 95.58% <100.00%> (+0.13%) ⬆️
generated/nifake/nifake/session.py 77.68% <100.00%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4860e...684db26. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants