Skip to content

Conversation

@rajsite
Copy link
Member

@rajsite rajsite commented Dec 22, 2025

Pull Request

🀨 Rationale

For the Storybook UI the PR follows the configured system theme to enable light or dark mode for the manager ui and the docs ui

πŸ‘©β€πŸ’» Implementation

  • Add a dark theme to the storybook theme
  • Use storybook's getPreferredColorScheme similar to how the storybook normal theme is implemented
  • Avoided changing the default selected theme for the canvas to the system theme as that had funny behavior. It stays defaulted to light theme.

πŸ§ͺ Testing

Tried storybook locally and rely on no Chromatic diffs.

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

brandImage: logoLight
});

const dark = create({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredvisser if you wanna give a quick review of the chosen values (I just eye-balled it). These impact the manager, addons, and docs parts of the ui but not the canvas renders. I'll make updates to the constants but it's night and weekends so any other changes will be follow-on.

@rajsite rajsite marked this pull request as ready for review December 22, 2025 05:13
@rajsite
Copy link
Member Author

rajsite commented Dec 22, 2025

@jattasNI @fredvisser bypass merging as it's not source changes and can handle feedback in nights-and-weekends as follow-on

@rajsite rajsite merged commit caf6ce0 into main Dec 22, 2025
11 checks passed
@rajsite rajsite deleted the sb-dark-mode branch December 22, 2025 05:14
@rajsite rajsite mentioned this pull request Dec 24, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants