[UpstreamMergeAutomation] Added details to PR description + clean up #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreejit-03
force-pushed
the
nilrt/master/scarthgap
branch
from
f03398a to
4cc4908
Compare
rajendra-desai-ni
requested changes
Nov 4, 2025
| - **`rt_target_IP`**: | ||
| The IP address or hostname of the RT target where images will be installed and tested via SSH. | ||
| - **`ssh_connection`**: | ||
| The SSH connection of the RT target where images will be installed. |
Contributor
There was a problem hiding this comment.
You can give a usage example something like: [username]@[hostname or IP address]
Contributor
Author
There was a problem hiding this comment.
I have made those changes.
| current_dir = os.getcwd() | ||
| push_and_pr_results = {} | ||
| for git_obj, (status, message) in list(merge_report.items()): | ||
| if status == 0 and message is not None: |
Contributor
There was a problem hiding this comment.
Isn't os.chdir(git_obj.local_repo) meant to cd to the absolute path of the submodule? If that's the case, you won't need to keep switching back to the current_dir at the end of every iteration.
Contributor
Author
There was a problem hiding this comment.
After the final PR is created, the working directory should return to the nilrt directory.
Shreejit-03
force-pushed
the
nilrt/master/scarthgap
branch
from
4cc4908 to
ff5215f
Compare
rajendra-desai-ni
approved these changes
Nov 5, 2025
Contributor
|
You might want to change the PR title and the commit message. Do add some more detail in the commit message after the title. |
Shreejit-03
force-pushed
the
nilrt/master/scarthgap
branch
from
ff5215f to
fc3545d
Compare
Shreejit-03
changed the title
Shreejit-03
force-pushed
the
nilrt/master/scarthgap
branch
from
fc3545d to
d294121
Compare
Shreejit-03
changed the title
Shreejit-03
changed the title
Shreejit-03
force-pushed
the
nilrt/master/scarthgap
branch
2 times, most recently
from
9c1a60c to
6af5773
Compare
Refined upstream merge automation by enhancing PR descriptions and cleaning up code. Removed hard-coded email IDs from configuration file. Signed-off-by: Shreejit-03 <shreejit.c@emerson.com>
Shreejit-03
force-pushed
the
nilrt/master/scarthgap
branch
from
6af5773 to
bd480cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
Justification
AB#3174387
Testing
Azure DevOps pipeline run completed successfully.
PRs were auto-created:
Mail report was generated and sent successfully.
@pratheekshasn
@rajendra-desai-ni