Skip to content

Conversation

@MostlyPride
Copy link

Allows the User to use ALT to move the Tick counter location on screen rather then it just being above your head. The other config options ie font size, font color still apply.

I love this plugin, and literally downloaded intelj compiled runelite forked this plugin and learned java to add this lmao. So please add the changes :)

Allows the User to use ALT to move the Tick counter location on screen rather then it just being above your head.  The other config options ie font size, font color still apply. 

I love this plugin, and literally downloaded intelj compiled runelite forked this plugin and learned java to add this lmao. So please add the changes :)
@@ -1,9 +1,10 @@
package com.attacktimer;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to change the package name here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name automatically adjusted due to it being compiled in my intelij.

I imagine if you swap it back to the original line it would be fine.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap the name back in your PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will give it a shot, was busy making some other things Ill try to get around to it tonight :)

@densep
Copy link

densep commented Jul 3, 2024

Please add this functionality. This would be so helpful.

this.plugin = plugin;
setPosition(OverlayPosition.DYNAMIC);
setLayer(OverlayLayer.UNDER_WIDGETS);
setPosition(OverlayPosition.TOP_LEFT);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit looks like it changes the default rendering - let's make sure that the default remains the same and any movability is opt-in via the config interface.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine anything that is giving a timer for your attacks you would want overlayed any other rendered objects.
That being said I can attempt to make it a option in the config.

@caraota-png
Copy link

Would love to see these changes made, the Attack Bar has become a must for me but being able to freely move it would make it even greater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants