-
Notifications
You must be signed in to change notification settings - Fork 28
Make Tick Counter Movable #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Allows the User to use ALT to move the Tick counter location on screen rather then it just being above your head. The other config options ie font size, font color still apply. I love this plugin, and literally downloaded intelj compiled runelite forked this plugin and learned java to add this lmao. So please add the changes :)
| @@ -1,9 +1,10 @@ | |||
| package com.attacktimer; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to change the package name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name automatically adjusted due to it being compiled in my intelij.
I imagine if you swap it back to the original line it would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you swap the name back in your PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will give it a shot, was busy making some other things Ill try to get around to it tonight :)
|
Please add this functionality. This would be so helpful. |
| this.plugin = plugin; | ||
| setPosition(OverlayPosition.DYNAMIC); | ||
| setLayer(OverlayLayer.UNDER_WIDGETS); | ||
| setPosition(OverlayPosition.TOP_LEFT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit looks like it changes the default rendering - let's make sure that the default remains the same and any movability is opt-in via the config interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine anything that is giving a timer for your attacks you would want overlayed any other rendered objects.
That being said I can attempt to make it a option in the config.
|
Would love to see these changes made, the Attack Bar has become a must for me but being able to freely move it would make it even greater. |
Allows the User to use ALT to move the Tick counter location on screen rather then it just being above your head. The other config options ie font size, font color still apply.
I love this plugin, and literally downloaded intelj compiled runelite forked this plugin and learned java to add this lmao. So please add the changes :)