fix: crypto does not work in http domain (specs)#120
Open
nuriddin2468 wants to merge 1 commit intongneat:masterfrom
Open
fix: crypto does not work in http domain (specs)#120nuriddin2468 wants to merge 1 commit intongneat:masterfrom
nuriddin2468 wants to merge 1 commit intongneat:masterfrom
Conversation
|
|
Author
|
@NetanelBasal up pls. |
Member
|
I don't see any reason to work with HTTP. I'm willing to merge a PR that accepts a custom function to generate the id, but we don't need this code in our bundle :) |
Author
|
During the development phase, we encountered challenges when testing certain features due to the necessity of using private endpoints. Unfortunately, this incompatibility led to disruptions in most of the library's dialog functionalities related to cryptographic specifications. But , we have already transitioned to our self-made workaround. I can close merge request if there is no need to this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing crypto package for generating uuid
What kind of change does this PR introduce?
Generating uuid now works without "crypto" package.
What is the current behavior?
While domain is working under HTTP , crypto does not exist, so it throws an error randomUUID function not found.
Source: click
Issue Number: N/A
What is the new behavior?
Now it generated uuid without crypto, so in HTTP domain it works fine
Does this PR introduce a breaking change?