Skip to content

feat: add angular animations and dialog close transition#108

Open
va-stefanek wants to merge 1 commit intongneat:masterfrom
va-stefanek:feature/40-dialog-transition
Open

feat: add angular animations and dialog close transition#108
va-stefanek wants to merge 1 commit intongneat:masterfrom
va-stefanek:feature/40-dialog-transition

Conversation

@va-stefanek
Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number: #40

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@va-stefanek va-stefanek force-pushed the feature/40-dialog-transition branch from e374ff2 to 0147475 Compare June 30, 2023 21:26
@va-stefanek
Copy link
Copy Markdown
Author

@NetanelBasal I have added new animation and migrated the old one to use angular animations. Solutions is strongly inspired by angular/components dialog.

@va-stefanek
Copy link
Copy Markdown
Author

@NetanelBasal up

@NetanelBasal
Copy link
Copy Markdown
Member

Can you tell why do we need this?

@danielkleebinder
Copy link
Copy Markdown

@NetanelBasal @va-stefanek
How's the status of this PR? Have been looking for this feature for quite some time now. I want to add some Material Design 3 close transitions to the dialogs of my hybrid mobile app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants