feat: add angular animations and dialog close transition#108
Open
va-stefanek wants to merge 1 commit intongneat:masterfrom
Open
feat: add angular animations and dialog close transition#108va-stefanek wants to merge 1 commit intongneat:masterfrom
va-stefanek wants to merge 1 commit intongneat:masterfrom
Conversation
|
|
e374ff2 to
0147475
Compare
Author
|
@NetanelBasal I have added new animation and migrated the old one to use angular animations. Solutions is strongly inspired by angular/components dialog. |
Author
Member
|
Can you tell why do we need this? |
|
@NetanelBasal @va-stefanek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number: #40