fix: Update metrics catalog #1673
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview will be available once build job completes!
|
russokj
reviewed
Jan 22, 2026
| | **Metric** | **Display Name** | **Dimensions** | **Type** | **Description** | **Roll-up per** | | ||
| |----------------------------------------|------------------|-----------------------------|-------|-----------------------------------------------------------------------------------------------------------------------------|---------------| | ||
| | system.cpu| CPU utilization | | count | System CPU Utilization. | deployment | | ||
| | system.cpu| CPU utilization | | average | System CPU Utilization. | deployment | |
Contributor
There was a problem hiding this comment.
Maybe where we talk about manual scaling, we should mention they should think about alerting on this metric.
russokj
approved these changes
Jan 22, 2026
Contributor
russokj
left a comment
russokj
left a comment
There was a problem hiding this comment.
Looks good. Just a minor suggestion.
Contributor
|
LGTM! Let's wait for LIFTR to deploy the new metric specification before we update the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change Type to average for system.cpu Metric for nginx azure in metrics-catalog.
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩