Skip to content

Conversation

@sean-breen
Copy link

Proposed changes

Adds packaging workflow for NGINX Agent.

  • Builds agent packages for all platforms
  • Zips and uploads to nginx repo

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@sean-breen sean-breen requested a review from a team as a code owner May 21, 2025 10:59
packageBuildNo:
type: string
default: "1"
tagRelease:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This input doesnt seem to be used.

build-and-upload-packages:
name: Build and upload Agent packages
runs-on: ubuntu-24.04-amd64
permissions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to duplicate permissions here if we already have it defined on the top-most level?

run:
shell: 'bash -Eeo pipefail -x {0}'

jobs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other workflows we also have a "sanity check" job that runs on public runners - and makes sure the workflow is instantiated from our orgs and through allowed events on known branches. See e.g.

While it's probably something that isnt strictly necessary, it's an additional check to make sure our self-hosted runners wont run the jobs they're not supposed to run.

export PATH=$PATH:~/go/bin
echo "$GPG_KEY" | base64 --decode > ${NFPM_SIGNING_KEY_FILE}
make package
echo "Run make package -> $VERSION $PACKAGE_BUILD"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and another hunk is probably a leftover debug?

@sean-breen
Copy link
Author

Closing as more changes required, will open a new PR

@sean-breen sean-breen closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants