_Ux86_64_setcontext should not read from stack after adjusting %rsp#1
Open
ngbronson-openai wants to merge 1 commit intomasterfrom
Open
_Ux86_64_setcontext should not read from stack after adjusting %rsp#1ngbronson-openai wants to merge 1 commit intomasterfrom
ngbronson-openai wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff changes _Ux86_64_setcontext so that it it doesn't read from its ucontext_t argument after adjusting %rsp, in case the ucontext_t is allocated on a portion of the stack that is inactive after that adjustment. This fixes a bug where signal delivery during c++ exception unwinding can trigger a segfault.
See libunwind#927 for a longer explanation and a repro, which was used to test this fix.