fix(util): fix _isVendor name collisions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the file names including the preceding `/` to account for similar files names. For example, `Restangular.js` would collide with `angular.js`, but `/Restangular.js` will not collide with `/angular.js`. This fixes most cases of name collision, unless there are two files with exact same names from different libraries. This is much less likely, but not impossible. There must be a better way of checking if a reference is to a vendor file!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the file names including the preceding
/to account for similar files names. For example,Restangular.jswould collide withangular.js, but/Restangular.jswill not collide with/angular.js.This fixes most cases of name collision, unless there are two files with exact same names from
different libraries. This is much less likely, but not impossible.
There must be a better way of checking if a reference is to a vendor file!