feat: add polar polygon support #585
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for polar polygons by splitting them by the meridian plane for display/query in 2D. Additionally, queries for OGC servers such as GeoServer are now split over the antimeridian in the event that the remote server does not allow coordinates outside of the longitudes [-180, 180]. resolves ngageoint#540, ngageoint#579
wallw-dev
commented
May 31, 2019
| "proj4": "+proj=stere +lat_0=90 +lat_ts=70 +lon_0=-45 +k=1 +x_0=0 +y_0=0 +datum=WGS84 +units=m +no_defs", | ||
| "title": "NSIDC Sea Ice Polar Stereographic North" | ||
| } | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
Not positive we want to include these. I hardcode the proj4 defs later on so that the polar split function can work even if they are not provided here (and they won't show up in the UI).
Contributor
Author
|
Ah, that test failure reminds me: JSTS, when splitting/polygonizing, does not linearly interpolate the altitude between the two points. Do we want to do that? |
wallw-dev
changed the title
bradh
pushed a commit
to bradh/opensphere
that referenced
this pull request
Jun 6, 2019
…here:THIN-12559 to master * commit 'd5322dd24c94ba4d9eff16b59b2eb5438bd4c159': fix(punyparent): fixed glitchyness fix(punyparent): fixed puny parent to debounce on change
wallw-dev
changed the title
jsalankey
reviewed
Jul 25, 2019
jsalankey
reviewed
Jul 25, 2019
jsalankey
reviewed
Jul 25, 2019
Contributor
Author
|
This algorithm does not work well for large polygons due to the stereographic projections. I'm considering adapting Cesium's approach of splitting the polygon by the meridian plane in 3D Cartesian space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for polar polygons by splitting them by the meridian plane for display/query in 2D. Additionally, queries for OGC servers such as GeoServer are now split over the antimeridian in the event that the remote server does not allow coordinates outside of the longitudes [-180, 180].
resolves #540, #579
Test: