feat(track): allow track truncation by time / age out #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidtk
suggested changes
Apr 22, 2021
| var timeNow = Date.now(); | ||
| var pointsToKeep = 0; | ||
| if (coords) { | ||
| coords.reverse().forEach(function(c) { |
Contributor
There was a problem hiding this comment.
os.track.getTimeIndex will get the closest index to a specified timestamp using binary search, so it may be more performant to:
- Get the closest index to the age-off timestamp.
- Splice the flat coordinates array from the index to the end.
- Do the same for metadata.
This would avoid the getCoordinates call which reconstitutes the flat coordinates (unnecessary GC of all those arrays), and reversing/iterating over the entire array.
| os.track.prunePointsAt_(track, geometry, numCoords); | ||
| }; | ||
|
|
||
| os.track.prunePointsAt_ = function(track, geometry, numCoords) { |
Contributor
There was a problem hiding this comment.
Missing JSDoc for this new function.
Contributor
|
@bradh FYI Travis stopped building OpenSphere, so you'll have to merge this branch with master to pick up the GH Actions builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.tracksupports truncation to a specified number of track points. I need something similar, but by age of the points.That is, old points in the track will be removed if they "age out" beyond a specified time.
The PR includes some minor refactoring and jsdoc fixes.