Skip to content

Conversation

@ryanslatten
Copy link
Contributor

This pr removes the mage, authentication, and navbar dependencies and converts them to Angular 14 components. It also removes left over unused files. The main upgrades are the login panel on the admin app and the navbar.

Testing instructions:

  1. Nagivate to the admin app. Verify that the Mage home, user profile, about, and logout buttons work as expected.
  2. Verify that the header and footer still work as expected on the admin page
  3. Logout on the admin page. Verify that you can still log in using the local login method.
  4. If you have LDAP and identity providers available, then set them up and then verify that they work as expected as well. There are docker containers for LDAP and saml that you can use or I can show it using my local instances.

Copy link

@S-S-T S-S-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the App:

  • Navigated to the admin app (#/home)
  • Mage Home route loads
  • User Profile opens from navbar
  • About page loads (#/about)
  • Logout works
  • Local login works after logout
  • Header / footer / navbar render correctly
    Console notes:
    ⚠️ Noted Angular reactive forms warning in ProfileComponent (non-blocking)
    ⚠️ Avatar request returns 404 locally, but fallback image is shown as expected
    ⚠️ Observed a 403 on /auth/token?createDevice=false during login in local env, but login completes successfully and app state is correct
    Code Review Summary:
    Added Angular 14 login modals, signin strategies, banner, contact module, and admin navigation; upgraded AngularJS from 1.5 → 1.8.3. Styling and TypeScript improvements included. Mostly safe and modular; main risk is AngularJS upgrade—test legacy code. No major issues otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants