Skip to content

Make sample names header-like#141

Open
fhausmann wants to merge 2 commits intonf-core:devfrom
fhausmann:fix_drimseq_samplenames
Open

Make sample names header-like#141
fhausmann wants to merge 2 commits intonf-core:devfrom
fhausmann:fix_drimseq_samplenames

Conversation

@fhausmann
Copy link
Copy Markdown

@fhausmann fhausmann commented May 31, 2024

Description of changes

The DRIMSEQ filtering pipeline is not running, when sample names contain special characters, due to automatic conversion. This automatic conversion is now applied also to the sample names.
This should fix #129, #140, #165.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@fhausmann fhausmann force-pushed the fix_drimseq_samplenames branch from c8898cb to b3b7682 Compare March 5, 2025 14:08
@fhausmann fhausmann changed the title Make sample names header-like, FIX #140 Make sample names header-like Mar 5, 2025
@lpantano
Copy link
Copy Markdown

lpantano commented Mar 5, 2026

@fhausmann do you want to update this to see if tests get triggered and we can merge?

@fhausmann
Copy link
Copy Markdown
Author

@lpantano I'm happy to update/work on this more if needed. However, I'm not sure what kind of update is required. As far as I can see, there are no merge conflicts. What updates are required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants