Skip to content

Conversation

@jkh00
Copy link
Collaborator

@jkh00 jkh00 commented Nov 27, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylong branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This patch release is meant to address some bugs.

  • fix caching issue
  • when --all-contexts is set, the default dmr analysis is by modkit because DSS only process CpG island.
  • remove --combine-strands in modkit pileup
  • all output, if possible should be compressed
  • update modkit versions
  • update modkit pileup module
  • replace --motif A 0 with --modified-bases 6mA in modkit pileup, because version v0.6.0 will give this error otherwise Error! single base motifs not supported, use --modified-bases.
  • update output structures and documentation
  • update affected subworkflows, where the modkit pileup module now directly output bgzf-compressed bedmethyl
  • inspect modkit pileup output

@jkh00
Copy link
Collaborator Author

jkh00 commented Nov 27, 2025

@nf-core-bot fix linting

nf-core-bot and others added 2 commits November 27, 2025 16:08
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
@YiJin-Xiong
Copy link
Member

@jkh00 Hiii, I noticed you mentioned there was still something to be done, and I was just wondering if you have any idea when it might be finished?😊

Signed-off-by: YiJin-Xiong <yshico@163.com>
@jkh00
Copy link
Collaborator Author

jkh00 commented Dec 5, 2025

Hii, I will try to implement some of them next week. But right now I have some other priorities, so it might be going in a slower pace.. you are more than welcome to contribute too! 😊 i think the compressing part should be easy to implement

@YiJin-Xiong
Copy link
Member

Sure! I'll try to handle them these two days!

YiJin-Xiong and others added 6 commits December 8, 2025 15:27
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
@jkh00
Copy link
Collaborator Author

jkh00 commented Dec 9, 2025

@YiJin-Xiong thanks alot for the help! I will get my hands on in the next two days :))

@jkh00
Copy link
Collaborator Author

jkh00 commented Dec 16, 2025

@nf-core-bot fix linting

@jkh00
Copy link
Collaborator Author

jkh00 commented Dec 18, 2025

@nf-core-bot fix linting

@jkh00
Copy link
Collaborator Author

jkh00 commented Dec 19, 2025

@nf-core-bot fix linting

@YiJin-Xiong
Copy link
Member

@jkh00 Is it ready to merge?

@jkh00
Copy link
Collaborator Author

jkh00 commented Dec 30, 2025

Hii @YiJin-Xiong

nope, theres a bug in the latest modkit pileup, where the compressing doesnt work when more than one motif is being pileup and some other bugs, I have opened an issue. there might be a fix soon. its a little tricky to workaround with the bugs ,so I'm planning to wait for the fix to incorporate that into this patch 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants