-
Notifications
You must be signed in to change notification settings - Fork 6
Patch 2.0.1 #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Patch 2.0.1 #78
Conversation
|
@nf-core-bot fix linting |
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
|
@jkh00 Hiii, I noticed you mentioned there was still something to be done, and I was just wondering if you have any idea when it might be finished?😊 |
Signed-off-by: YiJin-Xiong <yshico@163.com>
|
Hii, I will try to implement some of them next week. But right now I have some other priorities, so it might be going in a slower pace.. you are more than welcome to contribute too! 😊 i think the compressing part should be easy to implement |
|
Sure! I'll try to handle them these two days! |
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
|
@YiJin-Xiong thanks alot for the help! I will get my hands on in the next two days :)) |
|
@nf-core-bot fix linting |
|
@nf-core-bot fix linting |
|
@nf-core-bot fix linting |
|
@jkh00 Is it ready to merge? |
|
Hii @YiJin-Xiong nope, theres a bug in the latest modkit pileup, where the compressing doesnt work when more than one motif is being pileup and some other bugs, I have opened an issue. there might be a fix soon. its a little tricky to workaround with the bugs ,so I'm planning to wait for the fix to incorporate that into this patch 😊 |
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).This patch release is meant to address some bugs.
--all-contextsis set, the default dmr analysis is by modkit because DSS only process CpG island.--combine-strandsinmodkit pileupmodkit pileupmodule--motif A 0with--modified-bases 6mAinmodkit pileup, because version v0.6.0 will give this error otherwiseError! single base motifs not supported, use --modified-bases.modkit pileupmodule now directly output bgzf-compressed bedmethylmodkit pileupoutput