Open
Conversation
ewels
requested changes
Mar 2, 2026
| @@ -1,5 +1,5 @@ | |||
| process BOWTIE2_BUILD { | |||
| tag "$fasta" | |||
| tag "${fasta.baseName.replaceAll(/[^a-zA-Z0-9_-]/, '_')}" | |||
Member
There was a problem hiding this comment.
@edmundmiller this is an ancient PR, but you've modified shared modules here without updating them. Are these updated upstream? Can we do it that way then just pull in updates insatead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS tag validation issues were addressed by sanitizing process tags across multiple Nextflow modules. The primary problem involved illegal characters in tag values, such as
^in restriction sites or=in sample identifiers, which violate AWS resource label constraints.A consistent sanitization pattern,
replaceAll(/[^a-zA-Z0-9_-]/, '_'), was applied. This regex replaces any character not a letter, number, underscore, or hyphen with an underscore, ensuring AWS compliance.Specific changes include:
modules/local/hicpro/get_restriction_fragments.nf, theres_sitetag was sanitized (e.g.,^GATCbecomes_GATC).modules/local/hicpro/dnase_mapping_stats.nf,sampleandbamtags were combined and sanitized (e.g.,sample = file.bambecomessample___file_bam).modules/nf-core/bwa/index/main.nf,modules/nf-core/bowtie2/build/main.nf, andmodules/nf-core/custom/getchromsizes/main.nf,fastabase names were sanitized (e.g.,genome.fastabecomesgenome_fasta).modules/nf-core/cooler/makebins/main.nf, a syntax error"${meta.id}}"was corrected to"${meta.id}".These modifications ensure all generated process tags adhere to AWS naming conventions, resolving potential deployment errors.
Closes #224