-
Notifications
You must be signed in to change notification settings - Fork 21
v2.0.0: Refactor for sample-wise parameterisation #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
e4eea9d
e148a95
51281c7
5c92346
5c836b1
268a29b
0202358
4de24cc
4e98303
376973f
a8e9afc
5c5b2d2
d343d61
4ff031d
ce7a5a0
484c1d2
ae122c6
539f309
f2e0ca7
5579db4
39b5d38
97d2d13
6b1c1d7
daee6ee
2f95c5e
faddbdb
d428ddb
cbe5eea
d24eb8e
cd198cd
896617b
54fdedc
a66f51c
cd5c8eb
7ce8e7b
a475837
b789420
3f26436
0069ed2
9468b09
52708b6
8b4b157
14c129f
e52f31d
eba981c
93d3dd2
e745fd1
406e2e9
2dae481
8508e82
f7125b6
69e94a9
3b3948e
c3e2ae3
d7f0d52
47d656e
419eed6
65cdac7
9cc7003
4fadcf1
575654d
f26abb0
3be0f40
a03842e
1f6f2f9
3e528ef
67802f4
efb4dba
e324ac9
79ecc1e
3e45625
f89fe8f
16f2f22
26aacd4
71d8300
7cf82b4
acffbdc
1c8c7d0
723e865
0cc1bae
886cecb
bcc5fe3
b10a791
99cfebf
3e77ece
18f303f
36c3f54
1697bde
7df7552
bc6ab4a
926bf41
92711ed
71bdee6
c12bb98
803b66f
52c5aaf
161cc63
048421c
c9251a9
5fb4b72
9471bc3
a7de4d0
3b842d5
2013320
35ff8f0
0f8d169
5e6924a
ecc759c
f8499fd
403e1bb
6799326
a03f2f4
e9322ee
465b888
2a63c88
39bd223
ddf00a7
bb3147d
0e1964c
152a418
3092b2a
353a08d
e1b8649
11cf0cd
e2acf39
45a4442
7f3c155
e01d9d6
3d40b0b
9bb1748
3f06337
d8582ad
582a936
2991bd5
ccec260
97105a0
88fde2f
55a571b
6808b04
98b4c4d
20a2797
228e35a
96e3fc5
1886f34
452d475
22cbd74
5cc633b
494fd27
4e3f20a
1f11419
c725511
59e6bb1
2c08e3a
5c71d57
7765a61
b5949d3
4cf59b8
edef5f6
43fb04f
df608fa
8295789
47e5892
d23f008
83bdff7
0923ec6
5abe752
8257711
86bca4b
651a914
a8fd65f
aedc9c8
4f69670
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,4 @@ testing* | |
| null/ | ||
| .nf-test/ | ||
| .nf-test.log | ||
| schema.md | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,5 +14,3 @@ bin/ | |
| ro-crate-metadata.json | ||
| modules/nf-core/ | ||
| subworkflows/nf-core/ | ||
| *.svg | ||
| tests/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,53 @@ | |
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## v2.0.0 'Saffron Vulture' - [2026-xx-xx] | ||
|
|
||
| This is a major release, with breaking changes. | ||
| v2.0.0 of genomeassembler is a large refactor of the pipeline to facilitate sample-level parameteristation. This allows to either parameterise the _pipeline_ using `params`, or parameterise _samples_ via the `input` samplesheet. In case both types of parameterisations are used, sample parameters will take priority. | ||
|
|
||
| Since this workflow follows a sample-centric implementation, nextflow will always render the full pipeline dag, but depending on configuration samples may not travel through the whole pipeline. This may also cause terminal output to show task instances that will never become an active process. | ||
|
|
||
| In addition, v2.0.0 contains these changes: | ||
|
|
||
| ### `Added` | ||
|
|
||
| - fastplong for long-read trimming and qc | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know it is a bit difficult to do now, but in general it would be nice to include the PR# along each added feature (and the git handle of the person(s) who worked on it)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, fully agree. This all a massive PR, sadly there is only one person working on this (me). |
||
| - fastp for short-read trimming and qc | ||
| - migration to nf-test | ||
| - increased flexibility of the scaffolding strategy | ||
| - added option to group samples | ||
| - `dorado polish` added as an alternative to `medaka` for ONT polishing. This is an **experimental feature**, due to `dorado` being under active development. | ||
| - HiC scaffolding subworkflow: | ||
| - mapping with `bwamem2` or `minimap2` | ||
| - duplicate removal with `picard` | ||
| - scaffolding with `yahs` | ||
| - Switched to the versions topic, requires nextflow >=25.10.0 | ||
|
|
||
| ### `Fixed` | ||
|
|
||
| ### `Dependencies` | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you use the nf-core dependencies table for this, along with versions:
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How do I get this nf-core dependencies table? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Manual labor xD |
||
| - `fastplong` | ||
| - `fastp` | ||
| - `dorado` | ||
| - `bwamem2` | ||
| - `picard` | ||
| - `yahs` | ||
|
|
||
| ### `Deprecated` | ||
|
|
||
| The following tools are no longer used: | ||
|
|
||
| - `nanoq` | ||
| - `porechop` | ||
| - `lima` | ||
| - `trimgalor` | ||
|
|
||
| The following param is no longer implemented: | ||
|
|
||
| - `dump`, used to dump jellyfish output. | ||
|
|
||
| ## v1.1.0 'Brass Pigeon' - [2025-07-21] | ||
|
|
||
| ### `Added` | ||
|
|
@@ -72,3 +119,5 @@ Initial release of nf-core/genomeassembler, created with the [nf-core](https://n | |
| ### `Dependencies` | ||
|
|
||
| ### `Deprecated` | ||
|
|
||
| Codenames for v1.x are various types of metallic pigeons, v2.x are vultures of different colors. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| color: | ||
| palette: | ||
| green: "#24B064" | ||
| brown: "#3F2B29" | ||
| yellow: "#ECDC86" | ||
| white: "#f9f9f9" | ||
| gray-dark: "#343a40" | ||
| gray-100: "#f8f9fa" | ||
| gray-200: "#e9ecef" | ||
| gray-300: "#dee2e6" | ||
| gray-400: "#ced4da" | ||
| gray-500: "#adb5bd" | ||
| gray-600: "#6c757d" | ||
| gray-700: "#495057" | ||
| gray-800: "#343a40" | ||
| gray-900: "#212529" | ||
| background: white | ||
| foreground: gray-dark | ||
| primary: green | ||
| secondary: yellow | ||
| tertiary: brown | ||
| light: "#f8f9fa" | ||
| dark: "#212529" | ||
|
|
||
| logo: | ||
| images: | ||
| banner: "nf-core-logo.png" | ||
| apple: "nf-core-logo-square.png" | ||
| small: apple | ||
| medium: banner | ||
| large: banner | ||
|
|
||
| typography: | ||
| fonts: | ||
| - family: Maven Pro | ||
| source: google | ||
| base: Maven Pro | ||
| headings: Maven Pro |
Uh oh!
There was an error while loading. Please reload this page.