Skip to content

Release v.1.1.0#156

Merged
nschan merged 39 commits intomasterfrom
dev
Jul 21, 2025
Merged

Release v.1.1.0#156
nschan merged 39 commits intomasterfrom
dev

Conversation

@nschan
Copy link
Copy Markdown
Collaborator

@nschan nschan commented May 8, 2025

This PR is for a new release, v.1.1.0, including the template update -> 3.3.2

Major PRs included

The following PRs constitute the majority of changes in this PR, some small PRs, mostly those that fixed issues related to other PRs, are not listed:

#131 - Refactored QC steps into subworkflow.

#133 - Updated the input validation to be more strict. This should prevent some down the line errors in the pipeline

#136 - Switched to using ragtag patch instead of scaffold for flye_on_hifiasm

#138 - Switched to RagTag nf-core module

#142 - Switch --collect to accept a glob pattern instead of a folder, consistent with input validation.

#144 - Added hifiasm_on_hifiasm assembly strategy

#145 - Fixed --skip_assembly input validation bug.

#148 - Switched to LINKS nf-core module

#153 - Switched to nf-core template 3.2.1

#154 - Module maintenance:

  • updated hifiasm, minimap2, links nf-core modules
  • updated container in local quast module
  • separated modules.config into several files for easier navigation and maintenance

#157 - Make clear in output.mdthat paths should be absolute

#158 - Update reporting to not have my name in all generated reports, added tables for QUAST and BUSCO metrics in addition to plots, updated containers & env to include gt, used for table display.

#165 - Added extra checks if reference files exist.

#164 - Update to template 3.3.1

#170 - Update to template 3.3.2

nschan and others added 26 commits March 19, 2025 09:26
refactor qc into subworkflow
Replace local ragtag with the nf-core module

Use ragtag patch to create consensus assemblies
* update ragtag module

* update changelog
* check if assembly is skipped in initialization, closes #143

* update changelog
* make fix reads accept files, closes #141

* update changelog

---------

Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
* add hifiasm_ont_hifiasm_on_hifiasm profile, code, test, docs
* switch to LINKS nf-core module

* update changelog

* update LINKS args
This fixes an oversight where the mapping to reference was skipped with hifiasm_on_hifiasm, because the reads were not specified for this strategy.
* modules update

* subworkflow update after module update
* Template update for nf-core/tools version 3.2.1

* update changelog

* fix merge problem

* fix nf_core_version

* fix linting

* fix linting

* fix linting

* fix ci

* clean CI

* more memory for HIFIASM_ONT test

* more memory for HIFIASM tests

* change test limits

* move CI disk space cleanup

* fix CI test names

---------

Co-authored-by: Niklas Schandry <niklas@bio.lmu.de>
* newer quast

* fix busco inputs

* modules update

* update changelog

* avoid capturing python locale warning in quast version

* correct minimap2_align inputs

* separate configs for easier maintainance, change minimap2 preset to lr:hq for ONT reads

* update changelog
* version bump

* add codename
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 77843ad

+| ✅ 204 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.2
  • Run at 2025-07-21 08:44:37

nschan added 3 commits May 14, 2025 15:13
* update usage
* include tabular quast

* update report env

* add tables for busco

* update changelog
nschan added 3 commits May 22, 2025 16:28
* correct singularity https link
* add prefix to singularity container for report

* add files exist check for references, closes #165
@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

nf-core-bot and others added 5 commits July 1, 2025 09:36
* Template update for nf-core/tools version 3.2.1

* Template update for nf-core/tools version 3.3.1

* merge template 3.3.1 - fix linting

* update pre-commit

* merge template 3.3.1 - fix linting

* pre-commit config?

* pre-commit config?

* reinstall links

* try larger runner

* smaller run, disable bloom filter for hifiasm test

* updated test snapshot

* updated test snapshot

* update nftignore

* update nftignore

* update nftignore

* update nftignore

* update nftignore

* update nftignore

* update nftignore

* update nftignore

* update nftignore

* Update .github/actions/nf-test/action.yml

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>

* Update docs/output.md

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>

* remove .nf-test.log

---------

Co-authored-by: Niklas Schandry <niklas@bio.lmu.de>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
* update awk regex

* update snapshot
* add prefix to singularity container for report

* include gawk in gfa2fa env

* include gawk in gfa2fa env
* add prefix to singularity container for report

* include gawk in gfa2fa env

* include gawk in gfa2fa env

* mawk version

* mawk version in stub

* update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>

* [automated] Fix code linting

---------

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: nf-core-bot <core@nf-co.re>
* Template update for nf-core/tools version 3.2.1

* Template update for nf-core/tools version 3.3.1

* Template update for nf-core/tools version 3.3.2

* fix nf-core.yml

* Update nextflow.config

Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>

* restore nf-test.config

* restore ci

* remove duplicated line

* add nftignore

* add tests/nextflow.config

* exlcude svg from pre-commit

* bump CI NXF_VER

* bump CI NXF_VER

* end of file

* fix linting

* pull request template

* pull request template

---------

Co-authored-by: Niklas Schandry <niklas@bio.lmu.de>
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
* add prefix to singularity container for report

* maxime comments
Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two discretionary suggestions.

@nschan
Copy link
Copy Markdown
Collaborator Author

nschan commented Jul 21, 2025

Thanks a lot @maxulysse and @erikrikarddaniel for your reviews!

* add prefix to singularity container for report

* maxime comments

* comments Daniel Lundin

* update release date

* Revert "comments Daniel Lundin"

This reverts commit 376973f.

* Daniel Lundin comments
@nschan nschan merged commit ccf1b89 into master Jul 21, 2025
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants