Conversation
version bump 1.1.0dev
Json schema improvements
refactor qc into subworkflow
Replace local ragtag with the nf-core module Use ragtag patch to create consensus assemblies
* update ragtag module * update changelog
* add hifiasm_ont_hifiasm_on_hifiasm profile, code, test, docs
* switch to LINKS nf-core module * update changelog * update LINKS args
This fixes an oversight where the mapping to reference was skipped with hifiasm_on_hifiasm, because the reads were not specified for this strategy.
* modules update * subworkflow update after module update
* Template update for nf-core/tools version 3.2.1 * update changelog * fix merge problem * fix nf_core_version * fix linting * fix linting * fix linting * fix ci * clean CI * more memory for HIFIASM_ONT test * more memory for HIFIASM tests * change test limits * move CI disk space cleanup * fix CI test names --------- Co-authored-by: Niklas Schandry <niklas@bio.lmu.de>
* newer quast * fix busco inputs * modules update * update changelog * avoid capturing python locale warning in quast version * correct minimap2_align inputs * separate configs for easier maintainance, change minimap2 preset to lr:hq for ONT reads * update changelog
* version bump * add codename
|
* update usage
* include tabular quast * update report env * add tables for busco * update changelog
* correct singularity https link
* add prefix to singularity container for report * add files exist check for references, closes #165
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.2.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
* Template update for nf-core/tools version 3.2.1 * Template update for nf-core/tools version 3.3.1 * merge template 3.3.1 - fix linting * update pre-commit * merge template 3.3.1 - fix linting * pre-commit config? * pre-commit config? * reinstall links * try larger runner * smaller run, disable bloom filter for hifiasm test * updated test snapshot * updated test snapshot * update nftignore * update nftignore * update nftignore * update nftignore * update nftignore * update nftignore * update nftignore * update nftignore * update nftignore * Update .github/actions/nf-test/action.yml Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com> * Update docs/output.md Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com> * remove .nf-test.log --------- Co-authored-by: Niklas Schandry <niklas@bio.lmu.de> Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
* update awk regex * update snapshot
* add prefix to singularity container for report * include gawk in gfa2fa env * include gawk in gfa2fa env
* add prefix to singularity container for report * include gawk in gfa2fa env * include gawk in gfa2fa env * mawk version * mawk version in stub * update CHANGELOG * Update CHANGELOG.md Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * [automated] Fix code linting --------- Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> Co-authored-by: nf-core-bot <core@nf-co.re>
* Template update for nf-core/tools version 3.2.1 * Template update for nf-core/tools version 3.3.1 * Template update for nf-core/tools version 3.3.2 * fix nf-core.yml * Update nextflow.config Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io> * restore nf-test.config * restore ci * remove duplicated line * add nftignore * add tests/nextflow.config * exlcude svg from pre-commit * bump CI NXF_VER * bump CI NXF_VER * end of file * fix linting * pull request template * pull request template --------- Co-authored-by: Niklas Schandry <niklas@bio.lmu.de> Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
maxulysse
reviewed
Jul 11, 2025
maxulysse
reviewed
Jul 11, 2025
maxulysse
reviewed
Jul 11, 2025
maxulysse
reviewed
Jul 11, 2025
* add prefix to singularity container for report * maxime comments
erikrikarddaniel
approved these changes
Jul 21, 2025
Member
erikrikarddaniel
left a comment
There was a problem hiding this comment.
Just two discretionary suggestions.
Collaborator
Author
|
Thanks a lot @maxulysse and @erikrikarddaniel for your reviews! |
* add prefix to singularity container for report * maxime comments * comments Daniel Lundin * update release date * Revert "comments Daniel Lundin" This reverts commit 376973f. * Daniel Lundin comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for a new release, v.1.1.0, including the template update -> 3.3.2
Major PRs included
The following PRs constitute the majority of changes in this PR, some small PRs, mostly those that fixed issues related to other PRs, are not listed:
#131 - Refactored QC steps into subworkflow.
#133 - Updated the input validation to be more strict. This should prevent some down the line errors in the pipeline
#136 - Switched to using ragtag
patchinstead ofscaffoldforflye_on_hifiasm#138 - Switched to RagTag nf-core module
#142 - Switch
--collectto accept a glob pattern instead of a folder, consistent with input validation.#144 - Added
hifiasm_on_hifiasmassembly strategy#145 - Fixed
--skip_assemblyinput validation bug.#148 - Switched to
LINKSnf-core module#153 - Switched to nf-core template 3.2.1
#154 - Module maintenance:
hifiasm,minimap2,linksnf-core modulesquastmodulemodules.configinto several files for easier navigation and maintenance#157 - Make clear in
output.mdthat paths should be absolute#158 - Update reporting to not have my name in all generated reports, added tables for QUAST and BUSCO metrics in addition to plots, updated containers & env to include
gt, used for table display.#165 - Added extra checks if reference files exist.
#164 - Update to template 3.3.1
#170 - Update to template 3.3.2