HasMany: removeAll #788
HasMany: removeAll #788
Conversation
radimvaculik
force-pushed
the
feature/has-many-remove-all
branch
2 times, most recently
from
607cd60 to
cd07a7d
Compare
tests/cases/integration/Relationships/relationships.oneHasMany.removeAll.phpt
Show resolved
Hide resolved
Closes nextras#276.
radimvaculik
force-pushed
the
feature/has-many-remove-all
branch
from
cd07a7d to
f6a8cb9
Compare
| START TRANSACTION; | ||
| COMMIT; |
There was a problem hiding this comment.
There is no DELETE. Do you know why? @hrach
There was a problem hiding this comment.
:-O I do not. Hopefully, you have not discovered a bug.
There was a problem hiding this comment.
Looks buggy to me.
There was a problem hiding this comment.
Oh no, this is a real bug that has been hidden for many years.
Expected behavior:
- throw an exception, that (in this case) the TagFollowe::$author cannot be null, or
- delete the TagFollower if and only if the relationship is marked with a correct, currently non-existing, cascade marker, e.g.,
removeOrphan.
The second option is tracked in #205 and #278. Sadly, the current behavior does not rigger exception (either missing unsupported removeOrphan || non-nullable).
Supporting removeOrphan is a bit more difficult - we need to rewrite PersistenceHelper & RemovalHelper -> join the implementation together -> since the wanted behavior is in RemovalHelper, but needs to be triggered from PersistenceHelper.
As we are in the 5.1 RC phase, I would rather incline to trigger the exception. The working workaround is to call the TagFollower repository's remove().
2 participants
Closes #276.