Check for doc, but ignore options #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@zampino I accidentally overchecked if the ctx was a full document, but also including the option keys which are included in the empty doc. Does this look better to you? |
Merged
zampino
reviewed
Nov 28, 2025
| :nextjournal.markdown.impl/root :doc}) | ||
|
|
||
| (def essential-doc-keys (-> (set (keys empty-doc)) | ||
| (disj :text-tokenizers :text->id+emoji-fn))) |
Collaborator
There was a problem hiding this comment.
I'm lost in all our threads :-) Remind me why we cannot move the non-essential keys from the empty doc to some default options?
Collaborator
There was a problem hiding this comment.
But if we don't want to move them now, fine for me like this.
Contributor
Author
There was a problem hiding this comment.
This check is just there to merge in the default empty doc when it's not provided. So we have to check whether the user provided it or not.
Contributor
Author
|
I'll move this to #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.