Skip to content

chore: fix unrelated ci failures#1116

Open
hweihwang wants to merge 1 commit intomainfrom
chore/ci-failures-fix
Open

chore: fix unrelated ci failures#1116
hweihwang wants to merge 1 commit intomainfrom
chore/ci-failures-fix

Conversation

@hweihwang
Copy link
Copy Markdown
Contributor

@hweihwang hweihwang commented Mar 30, 2026

Summary

  • update firebase/php-jwt to v7 so static analysis can install cleanly with the current roave/security-advisories constraint
  • add a focused JWTService unit test that covers valid encode/decode flow and invalid token rejection
  • fix the Playwright test environment for php-jwt v7 by using a real-length shared secret for both the app config and the websocket server, which stops /apps/whiteboard/<id>/token from failing at runtime
  • split the Playwright matrix into 3 shards and stop collecting full CI traces/videos for every passing test
  • relax the multinode sync-reassignment wait that timed out on this PR under CI load

Verification

  • composer require --dev roave/security-advisories:dev-latest --dry-run
  • composer run psalm -- --threads=1 --monochrome --no-progress --output-format=console
  • php -r 'require "vendor/autoload.php"; echo \Firebase\JWT\JWT::encode(["x"=>1], "test-secret-key-with-at-least-32-bytes", "HS256");'
  • pnpm -s vitest run tests/integration/multinode-redis.spec.mjs
  • npx playwright test --list --shard=1/3

@hweihwang hweihwang force-pushed the chore/ci-failures-fix branch 5 times, most recently from 428b0a7 to 9f68f45 Compare March 30, 2026 16:09
@hweihwang hweihwang changed the title chore: update php-jwt to v7 chore: fix unrelated ci failures Mar 30, 2026
@hweihwang hweihwang force-pushed the chore/ci-failures-fix branch from 9f68f45 to 51b1ccd Compare March 30, 2026 16:21
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang hweihwang force-pushed the chore/ci-failures-fix branch from 51b1ccd to 783331c Compare March 30, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant