Conversation
solracsf
force-pushed
the
moveToITimeFactory
branch
from
c6fd933 to
34b80fc
Compare
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
moveToITimeFactory
branch
from
34b80fc to
04f9b43
Compare
julien-nc
requested changes
Mar 30, 2026
| public function __construct(array $tokenData) { | ||
| public function __construct( | ||
| array $tokenData, | ||
| private ITimeFactory $timeFactory, |
Member
There was a problem hiding this comment.
You could inject ITimeFactory in the constructor (and store it as a class attr as well) with OCP\Server::get to avoid having to pass it when instanciating tokens.
Member
Author
There was a problem hiding this comment.
It would work, but have a trade-off: it makes Token harder to test since you can't inject a mock ITimeFactory without having the full Nextcloud DI container available. WDYT?
julien-nc
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.