refactor: modernize session management and token validation#1390
Open
refactor: modernize session management and token validation#1390
Conversation
44990c5 to
e1b4226
Compare
julien-nc
requested changes
Mar 30, 2026
Member
julien-nc
left a comment
There was a problem hiding this comment.
Thanks a lot for refactoring this. Could you add a doc block comment for all the new methods with a global description? Especially if they change the overall behaviour of the backend.
julien-nc
reviewed
Mar 30, 2026
Member
Author
|
@julien-nc will adress all your comments at once ASAP. |
Member
|
@solracsf There is no rush 😁 |
e1b4226 to
c392b41
Compare
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
c392b41 to
7c966c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a comprehensive audit and refactor, resolving bugs and performance problems identified through iterative code review. Refactor user session management and token validation logic for improved clarity and functionality. Introduce constants for session data and enhance error handling.