📚 Add ecosystem bar to account chooser dialog

[AndyScherzinger]

• Resolves: Tighter integration on apps within Nextcloud ecosystem #3248
• ...by adding a (composable) Ecosystem bar
• Displays the ecosystem as described in Tighter integration on apps within Nextcloud ecosystem #3248 (comment)
• Adds a branding switcher, like Notes and Files clients (see setup.xml at https://github.com/nextcloud/talk-android/compare/feat/3248/ecosystem?expand=1#diff-6f6e1776d754790ae82df99359aa6c05672719665fe748686624c4769cc094deR27)
• Adds a settings option to turn it off (same as Notes and Files clients)
• Hides the Ecosystem bar for non-portrait layouts modes due to lack of space and on branded clients in general
• RTL/dark/light preview for the composable added
• Resolves some detekt issues to turn CI green

🖼️ Screenshots

⚙️ Settings	🏚️ Before/Off	🏡 After

🚧 TODO

• review and merge
• ping @tobiasKaminsky afterwards for Brander implementation (equivalent to Notes client)

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[miaulalala]

🐘

[jancborchardt]

Looks good, and nice positioning as discussed. :)

[mahibi]

Design wise it's fine.
Just the actual opening of the other apps fail for me.

I get

"Cannot open app store. Please install manually."

exception launching app [com.nextcloud.client, com.nextcloud.android.beta, com.nextcloud.android.qa]: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=com.nextcloud.intent.OPEN_ECOSYSTEM_APP flg=0x30000000 xflg=0x4 pkg=com.nextcloud.client (has extras) }

but i guess that's something to be improved/fixed on android-commons..

[AndyScherzinger]

@alperozturk96 to the rescue 😆

"Cannot open app store. Please install manually."

I guess cause it is a de-googlified phone?

exception launching app [com.nextcloud.client, com.nextcloud.android.beta, com.nextcloud.android.qa]: android.content.ActivityNotFoundException: No Activity found to handle Intent { act=com.nextcloud.intent.OPEN_ECOSYSTEM_APP flg=0x30000000 xflg=0x4 pkg=com.nextcloud.client (has extras) }

Might be the need for the latest version of the app @alperozturk96 upcoming 3.36 ?

[AndyScherzinger]

@tobiasKaminsky @AndyScherzinger right and we must support it?

Ecosystem bar is non-branded only on all our clients

What is the exact package name of the app you tried to open?

It is fully using the common implementation calling https://github.com/nextcloud/android-common/blob/main/core/src/main/java/com/nextcloud/android/common/core/utils/ecosystem/EcosystemManager.kt#L62

So the issue @mahibi ran into is the Files client not supporting https://github.com/nextcloud/android-common/blob/main/core/src/main/java/com/nextcloud/android/common/core/utils/ecosystem/EcosystemManager.kt#L37 which I guess is due to the fact that the Files app is too old and than it breaks, right? So it will only work with 3.36+?

[AndyScherzinger]

/backport to stable-23.0

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5868.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	98	98
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	54	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	81	81

[mahibi]

I guess cause it is a de-googlified phone?

No, not de-googled

So the issue @mahibi ran into is the Files client not supporting https://github.com/nextcloud/android-common/blob/main/core/src/main/java/com/nextcloud/android/common/core/utils/ecosystem/EcosystemManager.kt#L37 which I guess is due to the fact that the Files app is too old and than it breaks, right? So it will only work with 3.36+?

yes, tested with files 3.35.2

[mahibi]

works fine now when using a newer version of files app (tested with files version 3.37 alpha1)