Conversation
jancborchardt
left a comment
There was a problem hiding this comment.
It looks different from the message pinning style as far as I can see? Or does it work well in conjunction with that?
#5807
2 floating boxes would be fine. Ideal could be one floating box with a horizontal divider line, to save on space and visual complexity.
jancborchardt
left a comment
There was a problem hiding this comment.
Nevermind – saw #5867 just now :)
ab010e7 to
017c91a
Compare
mahibi
left a comment
There was a problem hiding this comment.
Would be nice to already follow the suggestion from #5867 (comment) to make it collapsible?
Otherwise fine for me to do this in followup PRs.
app/src/main/java/com/nextcloud/talk/models/json/upcomingEvents/UpcomingEvent.kt
Outdated
Show resolved
Hide resolved
@mahibi Yes, I will simply change it according to the discussion on the other item 👍 Yet I am unsure if that means, hide it forever? hide until you open the chat again or hide it based on the date of the event you display? WDYT @jancborchardt @nimishavijay ? |
There was a problem hiding this comment.
Yet I am unsure if that means, hide it forever? hide until you open the chat again or hide it based on the date of the event you display?
Probably best would be to:
- ✅ Always anyway show the "Upcoming call" box in the "Conversation info" view. Directly between conversation description and "Notification settings".
- ✅ If you x away the "Upcoming call" box that shows directly in the conversation view, show a notice saying "Upcoming call can be viewed in conversation info".
017c91a to
e3984d0
Compare
Resolves #5661 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
e3984d0 to
505b8dd
Compare
|
@mahibi implemented database layer change for dismissing and updated the design as discussed in the general design issue |
fixed review comments
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good!
This should be added as follow-up :) #5865 (review)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5865.apk |

🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x