Skip to content

fix(Propagator): Skip groupfolders root entries#58402

Merged
provokateurin merged 1 commit intomasterfrom
fix/propagator/skip-groupfolders-root-entries
Feb 18, 2026
Merged

fix(Propagator): Skip groupfolders root entries#58402
provokateurin merged 1 commit intomasterfrom
fix/propagator/skip-groupfolders-root-entries

Conversation

@provokateurin
Copy link
Member

This is for the "old" storage layout where all groupfolders were on a single storage.
Any change to any groupfolder caused the __groupfolders entry to be updated, causing locking issues on instances with lots of concurrent users.
This entry is actually not used at all by the clients, because only its subfolders are mounted, therefore the etag and mtime of it don't matter.

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added this to the Nextcloud 34 milestone Feb 18, 2026
@provokateurin provokateurin requested a review from a team as a code owner February 18, 2026 12:46
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Feb 18, 2026
@provokateurin provokateurin requested review from ArtificialOwl and removed request for a team February 18, 2026 12:47
@provokateurin
Copy link
Member Author

/backport to stable33

@provokateurin
Copy link
Member Author

/backport to stable32

@icewind1991
Copy link
Member

Might be better to have the groupfolder storage overwrite the propagator instead of having this logic in server.

@provokateurin
Copy link
Member Author

Right, I thought I'd have to override the whole propagateChange method, but of course it's enough to override the getParents method 👍

@provokateurin provokateurin deleted the fix/propagator/skip-groupfolders-root-entries branch February 18, 2026 14:38
@provokateurin provokateurin restored the fix/propagator/skip-groupfolders-root-entries branch February 18, 2026 14:48
@provokateurin provokateurin reopened this Feb 18, 2026
@provokateurin
Copy link
Member Author

I remember why I this needs to be in server 😅 The propagator for the groupfolders storage wouldn't handle these, as it only propagates within its storage, so overriding its getParents won't help at all.

@provokateurin
Copy link
Member Author

So I could add a custom propagator to LocalRootStorage and override getParents there, but in the end the fix has to be in server, so I don't think really matters.

@provokateurin provokateurin merged commit 3c8ca87 into master Feb 18, 2026
415 of 427 checks passed
@provokateurin provokateurin deleted the fix/propagator/skip-groupfolders-root-entries branch February 18, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments