Active share validation/authoritative mount improvements#57760
Draft
icewind1991 wants to merge 8 commits intomasterfrom
Draft
Active share validation/authoritative mount improvements#57760icewind1991 wants to merge 8 commits intomasterfrom
icewind1991 wants to merge 8 commits intomasterfrom
Conversation
icewind1991
requested review from
Altahrim,
ArtificialOwl,
nfebe and
salmart-dev
and removed request for
a team
icewind1991
force-pushed
the
share-update-check-single
branch
from
b1a28af to
054c5c0
Compare
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 23, 2026
…s for new share" Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 23, 2026
…s for new share" Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991
force-pushed
the
share-update-check-single
branch
from
054c5c0 to
3e548a5
Compare
CarlSchwan
approved these changes
Jan 26, 2026
icewind1991
force-pushed
the
share-update-check-single
branch
from
3e548a5 to
4851386
Compare
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Feb 6, 2026
Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991
force-pushed
the
share-update-check-single
branch
2 times, most recently
from
000d868 to
716d880
Compare
icewind1991
changed the title
icewind1991
force-pushed
the
share-update-check-single
branch
2 times, most recently
from
b35ead2 to
8e50698
Compare
icewind1991
changed the title
icewind1991
force-pushed
the
share-update-check-single
branch
2 times, most recently
from
4ba17d6 to
53326a9
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…number of users Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-update-check-single
branch
from
f29cc31 to
4b00db9
Compare
artonge
reviewed
Feb 18, 2026
| new Entry(self::SHOW_FEDERATED_TO_TRUSTED_AS_INTERNAL, ValueType::BOOL, false, 'shows federated shares to trusted servers as internal shares', true), | ||
| new Entry(self::EXCLUDE_RESHARE_FROM_EDIT, ValueType::BOOL, false, 'Exclude reshare permission from "Allow editing" bundled permissions'), | ||
|
|
||
| new Entry(self::UPDATE_SINGLE_CUTOFF, ValueType::INT, 10, 'For how many users do we update the share date immediately for single-share updates'), |
Contributor
There was a problem hiding this comment.
Date or data?
Suggested change
| new Entry(self::UPDATE_SINGLE_CUTOFF, ValueType::INT, 10, 'For how many users do we update the share date immediately for single-share updates'), | |
| new Entry(self::UPDATE_SINGLE_CUTOFF, ValueType::INT, 10, 'For how many users do we update the share data immediately for single-share updates'), |
Comment on lines
+71
to
+77
| if ($this->cutOffMarkAllSingleShare === -1 || $this->updatedCount <= $this->cutOffMarkAllSingleShare) { | ||
| $this->shareUpdater->updateForShare($user, $share); | ||
| // Share target validation might have changed the target, restore it for the next user | ||
| $share->setTarget($shareTarget); | ||
| } else { | ||
| $this->markUserForRefresh($user); | ||
| } |
Contributor
There was a problem hiding this comment.
Not sure that a user count make sense. I would rather base it on a time limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.