refactor(core): improve TwoFactorMiddleware clarity and maintainability #57297
+78
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the
beforeControllerfor improved clarity and maintainability while preserving all intended/existing behaviors:No logic is missing or altered in a way that would break original policy:
TODO
pollbypass for 2FA Notification app after fix: Add NoTwoFactorRequired attribute to poll method twofactor_nextcloud_notification#1151Checklist
3. to review, feature component)stable32)