feat(AppManager): log when cleanAppId drops invalid chars #56518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
added
enhancement
3. to review
joshtrichards
requested review from
provokateurin,
salmart-dev and
yemkareems
and removed request for
a team
provokateurin
approved these changes
Nov 19, 2025
susnux
approved these changes
Nov 19, 2025
come-nc
approved these changes
Nov 24, 2025
Log a debug message if invalid characters are replaced in app IDs. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/feat-appmanager-cleanappid-log
branch
from
7ca418c to
24ec0e8
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Log a debug message if invalid characters are replaced in app IDs. Otherwise stuff like
OCCWebresults in weird errors later in the code path likeAppPathNotFoundException: Could not find path for eb(real example from a community forum poster). Granted the exception will still happen, but at least there's a chance for this to be noticed during a troubleshooting situation.Was tempted to log this at least at info level, but suspect it would be too noisy.
TODO
Checklist
3. to review, feature component)stable32)