Skip to content

Fix empty filename not checked #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpivchev merged 2 commits into from
Aug 22, 2025
Merged

Fix empty filename not checked #3693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8184ce7
Add localizable
mpivchev Aug 21, 2025
bde3f60
Trim whitespaces
mpivchev Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iOSClient/Extensions/UIAlertController+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ extension UIAlertController {

let oldExtension = fileName.fileExtension

let text = alertController.textFields?.first?.text ?? ""
let text = alertController.textFields?.first?.text?.trimmingCharacters(in: .whitespaces) ?? ""
let textCheck = FileNameValidator.checkFileName(text, account: account, capabilities: capabilities)
var message = textCheck?.error.localizedDescription ?? ""
var messageColor = UIColor.red
Expand Down
1 change: 1 addition & 0 deletions iOSClient/Supporting Files/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ You can stop it at any time, adjust the settings, and enable it again.";
"_file_name_validator_error_invalid_character_" = "Name contains an invalid character: \"%@\".";
"_file_name_validator_error_space_" = "Name must not contain spaces at the beginning or end.";
"_file_name_new_extension_" = "Changing the extension might cause this file to open in a different application.";
"_file_name_empty_" = "File name cannot be empty.";
"_please_rename_file_" = "Please rename the file or folder.";
"hidden_file_name_warning" = "Name will result in a hidden file.";

Expand Down
Loading