Skip to content

Comments

Custom share permissions#3459

Merged
mpivchev merged 34 commits intomasterfrom
add-share-permissions
May 30, 2025
Merged

Custom share permissions#3459
mpivchev merged 34 commits intomasterfrom
add-share-permissions

Conversation

@mpivchev
Copy link
Collaborator

@mpivchev mpivchev commented May 5, 2025 •
edited
Loading

mpivchev added 19 commits April 2, 2025 15:00
@mpivchev
Add read permission indicator + refactor
969f8ef 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
e92ac49 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
4647e9e 
…are-permissions
@mpivchev
WIP
b473eb3 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
fefa242 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Download and sync in advanced
f8a77ea 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Make download and sync button work
d6adbb2 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Remove download from normal permissions
935fdcf 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Remove unneeded db param
c2b8fd1 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Fix view only, allow edit, custom permissions
5889f64 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Fix link custom permissions being grayed out
219df5a 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
7fc9a8a 
…are-permissions
@mpivchev
Fix share screen not updating with sharees on first open
bd87c2b 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Refactor
e6098fb 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Add capabilities check for download limit
4637451 
This removes the api error

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
6aae638 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
b2140cc 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
e58020b 
…are-permissions

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Add quick options to link shares
2288d34 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev mpivchev mentioned this pull request May 5, 2025
Closed
@mpivchev mpivchev requested a review from alperozturk96 May 6, 2025 08:44
mpivchev added 5 commits May 6, 2025 18:23
@mpivchev
WIP
d5d5dbf 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Add selected flag to file drop
1d6ef84 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Remove share permission on email shares
05f0485 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Refactor
559ef53 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
5a450ac 
…are-permissions
@mpivchev mpivchev requested review from i2h3 and marinofaggiana May 7, 2025 13:06
alperozturk96

This comment was marked as resolved.

Sign in to view

@alperozturk96

This comment was marked as resolved.

Sign in to view
@alperozturk96

This comment was marked as resolved.

Sign in to view
@alperozturk96
Copy link

alperozturk96 commented May 7, 2025

Screen.Recording.2025-05-07.at.15.23.36.mp4

mpivchev added 2 commits May 7, 2025 15:33
@mpivchev
Fix shares not showing
9186989 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Fix ui
5375499 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@i2h3
Copy link
Contributor

i2h3 commented May 9, 2025 •
edited
Loading

When I select custom permissions which basically are read and reshare only (screenshot 1) and open the sheet of the permissions line, then always "view only" is selected and not custom permissions as expected.

Strangely, after editing the custom permissions (adding "create" permission), nothing is checked anymore.

Selection1
Selection2

i2h3
i2h3 requested changes May 9, 2025
View reviewed changes
iOSClient/Share/Advanced/NCShareAdvancePermission.swift Outdated
}

Task {
// TODO: Apply share token to download limit object
Copy link
Contributor

@i2h3 i2h3 May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed due to the update below.

@mpivchev
Refactor
151ff20 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev mpivchev mentioned this pull request May 14, 2025
Closed
mpivchev added 2 commits May 15, 2025 14:55
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
7d67a04 
…are-permissions
@mpivchev
PR changes
b2fca73 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Copy link
Collaborator Author

mpivchev commented May 16, 2025 •
edited
Loading

  • Clarify if Delete should be part of Files link shares
  • Enabled federated sharing, MUST TEST with Alper
  • Federated share has missing name
  • Share link (2) on web shows the (2), but not on iOS. Must be part of the API. Check.
  • Sharing from crud.ltd3.. to tos.ltd3 TOS federated group fails on Web. Report as a bug
  • Check why sharing with Deck returns an error (with Julius) [Bug]: Sharing to Deck card successful, but still shows an error deck#7300
  • Change icon to group (circle) icon, as web
  • Talk to Jan about the broken circle icon on web
  • Talk share type should show (conversation)
  • Talk to Jan about icon not being the Talk logo
  • User1 shares to user3, user3 can reshare with user1, which does not make sense. user1 should not appear.
  • If user2 has already shared with user1, he should also not be able to select user1 again. Also check Android with Alper.
  • Not allowed resharing, but contact book icon appears, must remove

mpivchev added 5 commits May 16, 2025 15:27
@mpivchev
PR changes
ebe9ab3 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
f736cd4 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Prevent user from choosing themselves
64becc2 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Do not show already existing sharees
3cf367d 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
ff67bb1 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Copy link
Collaborator Author

mpivchev commented May 27, 2025

@marinofaggiana @i2h3 i did testing with alper and tobias on this. please only review the code.

i2h3
i2h3 approved these changes May 28, 2025
View reviewed changes
@mpivchev mpivchev merged commit 5c000ed into master May 30, 2025
5 checks passed
@i2h3 i2h3 deleted the add-share-permissions branch June 3, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i2h3 i2h3 i2h3 approved these changes

@marinofaggiana marinofaggiana marinofaggiana approved these changes

@alperozturk96 alperozturk96 Awaiting requested review from alperozturk96

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mpivchev @alperozturk96 @i2h3 @marinofaggiana