Skip to content

Update Runner.php to avoid "Force Quit" situation and allow the job to be finished #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ferdiga wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Runner.php to avoid "Force Quit" situation and allow the job to be finished #870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/Model/Runner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,12 +393,18 @@ private function updateTick(int $tick, string $action) {

try {
$this->runningService->update($this->tickId, $action);
$this->tickUpdate = $tick;
} catch (TickIsNotAliveException $e) {
$this->output('Force Quit');
exit();
$this->output('No Force Quit');
/**
* ToDo: we must collect all errors and publish the error messages once the job finishes
* to allow the admin or the user to fix the problems or accept that not all files are indexed.
* Obviously there are probably many more files not indexed if the "Force Quit" cause can not be fixed for some reason.
* exit();
*/
}

$this->tickUpdate = $tick;

}


Expand Down