[stable33] Fix handling of "enableScripting" data attribute#1398
Draft
backportbot[bot] wants to merge 3 commits intostable33from
Draft
[stable33] Fix handling of "enableScripting" data attribute#1398backportbot[bot] wants to merge 3 commits intostable33from
backportbot[bot] wants to merge 3 commits intostable33from
Conversation
In PHP, a boolean is converted to a string as either "1" or "" rather than to "true" or "false". Moreover, the value of the data attribute is always returned as a string in JavaScript, so it never matched a strict comparison against a boolean value. It would be possible to fix this by comparing against "1" in Javascript. However, for clarity (and given that semantically an existing data attribute would be considered a boolean true if present, even if empty), now the "enableScripting" data attribute is explicitly set to either "true" or "false" and the comparison in JavaScript is done against a string "true". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1396
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.