Skip to content

Add psalm workflow #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
come-nc wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add psalm workflow #175

come-nc wants to merge 3 commits into from

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 9, 2022

No description provided.

@come-nc come-nc self-assigned this Jun 9, 2022
@come-nc come-nc requested a review from ArtificialOwl June 9, 2022 15:03
@come-nc
Copy link
Contributor Author

come-nc commented Jun 9, 2022

Lots of OC\ usage, if they are not removable we should stub them.

This one seem like a valid concern:

ERROR: InvalidPropertyAssignmentValue - lib/Provider/FilesProvider.php:94:26 - $this->indexOptions with declared type 'OCP\FullTextSearch\Model\IIndexOptions' cannot be assigned type 'array<empty, empty>' (see https://psalm.dev/145)
61
	private $indexOptions = [];

The property is indeed passed to methods which only accepts an IIndexOptions instance.

@come-nc
Copy link
Contributor Author

come-nc commented Sep 29, 2022

/rebase

1 similar comment
@come-nc
Copy link
Contributor Author

come-nc commented Sep 30, 2022

/rebase

@come-nc
Add psalm configuration
a981376 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add psalm workflow
d2f4530 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enh/add-psalm-workflow branch from 75bd7e6 to d2f4530 Compare September 30, 2022 12:58
@come-nc
Use psalm.yml from nextcloud/.github
24c1da6 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc removed their assignment Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@come-nc