Skip to content

Android: add notes for multiple stable versions #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasKaminsky merged 1 commit into from
Dec 18, 2025
Merged

Android: add notes for multiple stable versions #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 44 additions & 5 deletions translations/handlePlainTranslations.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,45 @@ default_branch=$(git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remote
versions="$default_branch $(git branch -r | grep -E "origin\/stable\-[0-9\.]+$" | cut -f2 -d"/" | sort -r | head -n1)"

# combine stable branches to keep freshly removed translations
if [ $1 = "nextcloud" -a $2 = "android" ] ||
[ $1 = "nextcloud" -a $2 = "android-library" ] ||
[ $1 = "nextcloud" -a $2 = "notes-android" ] ||
[ $1 = "nextcloud" -a $2 = "talk-android" ] ||
; then
if [ $1 = "nextcloud" -a $2 = "android" ]; then
mkdir stable-values
for version in $versions
do
git checkout $version

cp app/src/main/res/values/strings.xml stable-values/$version.xml
done

cd stable-values
echo '<?xml version="1.0" encoding="utf-8"?>
<resources>' >> combined.xml

grep -h "<string" *.xml | sort -u | sed s'#\t# #'g >> combined.xml

# plurals are hard to compare, so we take only master/main ones
awk '/<plurals/,/<\/plurals>/' "$default_branch.xml" >> combined.xml

echo "</resources>" >> combined.xml

cat combined.xml

duplicated_translations=$(cat combined.xml | grep 'name="([^"]*)"' -E -o | sort | uniq -c | grep -v '1 name' | wc -l)
if [ $duplicated_translations != "0" ]; then
echo ""
echo ""
echo "💥 Some translation strings have a different English source text between branches:"
cat combined.xml | grep 'name="([^"]*)"' -E -o | sort | uniq -c | grep -v '1 name' | grep 'name="([^"]*)"' -E -o
exit 1
fi

mv combined.xml ../app/src/main/res/values/strings.xml

cd ..

rm -rf stable-values
fi

if [ $1 = "nextcloud" -a $2 = "notes-android" ]; then
mkdir stable-values
for version in $versions
do
Expand Down Expand Up @@ -146,6 +180,11 @@ if [ $1 = "nextcloud" -a $2 = "android" ]; then
git checkout $default_branch
fi

if [ $1 = "nextcloud" -a $2 = "notes-android" ]; then
git checkout -- app/src/main/res/values/strings.xml
git checkout $default_branch
fi

if [ $1 = "nextcloud" -a $2 = "android-common" ]; then
git checkout -- core/src/main/res/values/strings.xml
git checkout $default_branch
Expand Down