Integrated NextcloudFileProviderKit Repository #9176
Merged
+22,135
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Implement paginated enumeration
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Add Item user info property reporting whether it is shareable or not
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
It's not used by any users of this library and there is no interest in this feature Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…ystem and custom pagination tokens for this Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…or when handling working set folders Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…ed propfinds Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Implement more gentle depth-1 paginated PROPFIND approach for working set enumeration
…lities Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…f items Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Fully handle permissions in Item capabilities
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…NKFile Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
…3/chore/nextcloudfileproviderkit-migrated
i2h3
force-pushed
the
i2h3/chore/nextcloudfileproviderkit-migrated
branch
from
de28071 to
c4ca1d6
Compare
… local reference. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
…leProviderUIExt target. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
… project. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
…derKit. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
Collaborator
Author
|
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates the NextcloudFileProviderKit repository into the desktop client repository by merging its contents into a subdirectory (shell_integration/MacOSX/NextcloudFileProviderKit) while preserving Git history. The PR adds comprehensive test suites covering various aspects of the File Provider Kit functionality.
Key Changes
- Added extensive test coverage for item operations (create, modify, delete, fetch)
- Implemented test infrastructure including mock observers and enumerators
- Added database manager tests, account tests, and enumeration tests
- Included utility tests for chunked arrays and file matching
Reviewed changes
Copilot reviewed 92 out of 109 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ItemModifyTests.swift | Tests for file/folder modifications, trashing, and bundle operations |
| ItemMetadataTests.swift | Tests for item metadata functionality including thumbnail URLs |
| ItemFetchTests.swift | Tests for fetching file and directory contents |
| ItemDeleteTests.swift | Tests for file/folder deletion and trashing operations |
| ItemCreateTests.swift | Tests for creating files, folders, and bundles |
| IgnoredFilesMatcherTests.swift | Tests for pattern matching of ignored files |
| FilesDatabaseManagerTests.swift | Tests for database operations including CRUD and synchronization |
| EnumeratorTests.swift | Tests for file enumeration, pagination, and working set functionality |
| EnumeratorPageResponseTests.swift | Tests for pagination response handling |
| ChunkedArrayTests.swift | Tests for chunked array utilities and concurrent operations |
| AccountTests.swift | Tests for account initialization and properties |
| MockRemoteInterfaceTests.swift | Tests for mock remote interface operations |
| MockEnumerator.swift | Mock enumerator implementation for testing |
| MockEnumerationObserver.swift | Mock observer for enumeration testing |
| MockChangeObserver.swift | Mock observer for change enumeration testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Artifact containing the AppImage: nextcloud-appimage-pr-9176.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Closed
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual changes to review are the few little commits after the merge commit of the whole repository history of NextcloudFileProviderKit!
I have merged the NextcloudFileProviderKit repository into this desktop client repository and moved its contents into a subdirectory (
shell_integration/MacOSX/NextcloudFileProviderKit) while retaining the Git history.Closes nextcloud/nextcloudfileproviderkit#136
Left To Do
masterof this repository works with themainof the integrated package repository.i2h3/proper-macos-sandboxingbranch is required.