Skip to content

Prepare 3.2.0 #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasdotcom merged 1 commit into from
Mar 16, 2026
Merged

Prepare 3.2.0 #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,27 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## 3.2.0 – 2026-03-16

### Added

- Only share to users and groups when necessary [#389](https://github.com/nextcloud/approval/pull/389) @lukasdotcom
- Add support for Nextcloud 34

### Changed

- Implement typescript [#381](https://github.com/nextcloud/approval/pull/381) @lukasdotcom

### Fixed

- Improve testing [#392](https://github.com/nextcloud/approval/pull/392) @lukasdotcom
- Ensure rich parameters are strings [#391](https://github.com/nextcloud/approval/pull/391) @SystemKeeper
- Update README.md [#387](https://github.com/nextcloud/approval/pull/387) @Jerome-Herbinet
- Hide batch action for respondAction [#382](https://github.com/nextcloud/approval/pull/382) @lukasdotcom
- FileAction class was removed from @nextcloud/files [#380](https://github.com/nextcloud/approval/pull/380) @julien-nc
- Show selected tags in workflow admin / Fix workflow when manually triggered via tag assignment [#376](https://github.com/nextcloud/approval/pull/376) @kesselb
- Replace getById with getFirstNodeById [#375](https://github.com/nextcloud/approval/pull/375) @CarlSchwan

## 3.1.0 - 2026-01-23

### Changed
Expand Down
4 changes: 2 additions & 2 deletions appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Approve/reject files based on workflows defined by admins.
**Warning**: The DocuSign integration is no longer part of this app
and can be installed with [this app](https://apps.nextcloud.com/apps/integration_docusign).
]]></description>
<version>3.1.0</version>
<version>3.2.0</version>
<licence>agpl</licence>
<author>Julien Veyssier</author>
<namespace>Approval</namespace>
Expand All @@ -32,7 +32,7 @@ and can be installed with [this app](https://apps.nextcloud.com/apps/integration
<screenshot>https://github.com/nextcloud/approval/raw/main/img/screenshot_2.jpg</screenshot>
<screenshot>https://github.com/nextcloud/approval/raw/main/img/screenshot_3.jpg</screenshot>
<dependencies>
<nextcloud min-version="33" max-version="33"/>
<nextcloud min-version="33" max-version="34"/>
</dependencies>
<settings>
<admin>OCA\Approval\Settings\Admin</admin>
Expand Down
4 changes: 2 additions & 2 deletions lib/Service/ApprovalService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,8 +868,8 @@ public function propFind(PropFind $propFind, INode $node): void {
*/
public function removeApprovalTags(Node $file): void {
$fileId = $file->getId();
$fileTags = $this->tagObjectMapper->getTagIdsForObjects([$fileId], 'files');
$fileTags = $fileTags[$fileId] ?? [];
$fileTags = $this->tagObjectMapper->getTagIdsForObjects([(string)$fileId], 'files');
$fileTags = $fileTags[(string)$fileId] ?? [];
if (count($fileTags) > 0) {
$tags = $this->ruleService->filterApprovalTags($fileTags);
foreach ($tags as $tag) {
Expand Down
Loading