Skip to content

fix: Ensure rich parameters are strings#391

Merged
lukasdotcom merged 1 commit intomainfrom
fix/noid/notification-parsing
Mar 16, 2026
Merged

fix: Ensure rich parameters are strings#391
lukasdotcom merged 1 commit intomainfrom
fix/noid/notification-parsing

Conversation

@SystemKeeper
Copy link
Copy Markdown
Contributor

Noticed while testing #389.

Notification was claimed to be parsed, but was not fully parsed by OCA\Approval\Notification\Notifier [app: approval, subject: manual_request]

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Copy link
Copy Markdown
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you

Copy link
Copy Markdown
Member

@lukasdotcom lukasdotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lukasdotcom lukasdotcom merged commit 5a47805 into main Mar 16, 2026
41 checks passed
@lukasdotcom lukasdotcom deleted the fix/noid/notification-parsing branch March 16, 2026 14:37
@lukasdotcom lukasdotcom mentioned this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants