Skip to content

Comments

Albums functionality#14947

Open
surinder-tsys wants to merge 27 commits intomasterfrom
nmc/albums
Open

Albums functionality#14947
surinder-tsys wants to merge 27 commits intomasterfrom
nmc/albums

Conversation

@surinder-tsys
Copy link
Collaborator

@surinder-tsys surinder-tsys commented Jun 2, 2025

This PR contains the new Albums Functionality.

Library PR: nextcloud/android-library#1736

  • Tests written, or not not needed

@surinder-tsys

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

alperozturk96

This comment was marked as resolved.

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 🤖 🍏 Mobile clients team Feb 2, 2026
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 🤖 🍏 Mobile clients team Feb 2, 2026
@alperozturk96 alperozturk96 force-pushed the nmc/albums branch 2 times, most recently from 8a12b7f to 2bd2ea3 Compare February 3, 2026 09:19
@nextcloud nextcloud deleted a comment from github-actions bot Feb 3, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Feb 3, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Feb 3, 2026
@alperozturk96

This comment was marked as resolved.

surinder-tsys and others added 17 commits February 19, 2026 14:06
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

# Conflicts:
#	gradle/libs.versions.toml
Signed-off-by: A117870935 <surinder.kumar@t-systems.com>
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Copy link
Collaborator

alperozturk96 commented Feb 19, 2026

Empty album

Screenshot_20260219_155402

Album overview

@kra-mo @tobiasKaminsky what do you think?

Before After
before after after

Album items action

Screenshot_20260219_163417

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@kra-mo
Copy link
Member

kra-mo commented Feb 20, 2026

@kra-mo @tobiasKaminsky what do you think?

I think it is an improvement, but the shadow is quite strong and it makes the rounded bottom corners also make less sense imo. Could we use the outlined card style? Other than that, looks good :)

Co-authored-by: Laura Kramolis <git@kramo.page>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@github-actions
Copy link

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7575
Dodgy code256256
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4446
Security1818
Total479481

SpotBugs increased!

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14947.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

5 participants