fix(#195): Handle zero-byte downloads correctly.#196
Merged
Conversation
When downloading zero byte files previously, the responseData handler raises an error while the plain response handler meant for file downloads does not. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #195 by fixing a zero-byte download handling issue. The problem occurred when downloading empty files - the responseData handler would raise an error while the plain response handler works correctly for file downloads regardless of size.
Key Changes:
- Replaced
responseDatahandler withresponsehandler for download completion handling - Changed error handling from switch statement to if-let pattern matching
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nilsding
approved these changes
Oct 15, 2025
github-project-automation
bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 💻 Desktop Clients team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading zero byte files previously, the responseData handler raises an error while the plain response handler meant for file downloads does not.