Skip to content

task.resume #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marinofaggiana merged 1 commit into from
Jun 29, 2025
Merged

task.resume #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Sources/NextcloudKit/NextcloudKitBackground.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel
public func download(serverUrlFileName: Any,
fileNameLocalPath: String,
taskDescription: String? = nil,
automaticResume: Bool = true,
account: String) -> (URLSessionDownloadTask?, error: NKError) {
var url: URL?
let groupDefaults = UserDefaults(suiteName: NextcloudKit.shared.nkCommonInstance.groupIdentifier)
Expand Down Expand Up @@ -69,7 +70,10 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel

let task = nkSession.sessionDownloadBackground.downloadTask(with: request)
task.taskDescription = taskDescription
task.resume()

if automaticResume {
task.resume()
}

return (task, .success)
}
Expand All @@ -84,6 +88,7 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel
public func downloadAsync(serverUrlFileName: Any,
fileNameLocalPath: String,
taskDescription: String? = nil,
automaticResume: Bool = true,
account: String) async -> (
downloadTask: URLSessionDownloadTask?,
error: NKError
Expand All @@ -92,6 +97,7 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel
let (task, error) = download(serverUrlFileName: serverUrlFileName,
fileNameLocalPath: fileNameLocalPath,
taskDescription: taskDescription,
automaticResume: automaticResume,
account: account)
continuation.resume(returning: (downloadTask: task, error: error))
}
Expand Down Expand Up @@ -121,6 +127,7 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel
taskDescription: String? = nil,
overwrite: Bool = false,
account: String,
automaticResume: Bool = true,
sessionIdentifier: String) -> (URLSessionUploadTask?, error: NKError) {
var url: URL?
var uploadSession: URLSession?
Expand Down Expand Up @@ -182,7 +189,10 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel

let task = uploadSession?.uploadTask(with: request, fromFile: URL(fileURLWithPath: fileNameLocalPath))
task?.taskDescription = taskDescription
task?.resume()

if automaticResume {
task?.resume()
}

return (task, .success)
}
Expand All @@ -201,6 +211,7 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel
taskDescription: String? = nil,
overwrite: Bool = false,
account: String,
automaticResume: Bool = true,
sessionIdentifier: String) async -> (
uploadTask: URLSessionUploadTask?,
error: NKError
Expand All @@ -213,6 +224,7 @@ public final class NKBackground: NSObject, URLSessionTaskDelegate, URLSessionDel
taskDescription: taskDescription,
overwrite: overwrite,
account: account,
automaticResume: automaticResume,
sessionIdentifier: sessionIdentifier)
continuation.resume(returning: (uploadTask: task, error: error))
}
Expand Down
Loading