Fix broken macOS build caused by uploadChunk changes#151
Merged
marinofaggiana merged 1 commit intomainfrom Jun 15, 2025
Merged
Conversation
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the broken macOS build by updating the error handling in the upload process. The change involves updating the completion call by removing an extra nil parameter and replacing the error object with a concise enum value.
- Updated error parameter in the completion call in NextcloudKit+Upload.swift.
- Removed an extra parameter from the completion function call.
Comments suppressed due to low confidence (1)
Sources/NextcloudKit/NextcloudKit+Upload.swift:141
- Ensure that the updated completion function signature now accepts four parameters after removing the previously provided nil value. Confirm consistency with the updated error handling API.
return completion(account, nil, nil, .errorChunkNoEnoughMemory)
mgallien
approved these changes
Jun 13, 2025
i2h3
approved these changes
Jun 13, 2025
marinofaggiana
approved these changes
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.