Merged
Conversation
i2h3
approved these changes
May 19, 2025
Collaborator
i2h3
left a comment
i2h3
left a comment
There was a problem hiding this comment.
I would remove the default values from the property declarations, though. Then there is no ambiguity or confusion when reading the code from where a default value originates and it is cleaner.
Contributor
Author
Good point, I added a commit removing the default property values |
i2h3
approved these changes
May 20, 2025
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
tobiasKaminsky
force-pushed
the
feature/public-nkfile-init
branch
from
a29c524 to
7118a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also needed for mocking in NCFPK