Merged
Conversation
claucambra
force-pushed
the
feature/exposed-nkrequestoptions
branch
3 times, most recently
from
1f82bc3 to
91623aa
Compare
claucambra
changed the title
i2h3
approved these changes
May 19, 2025
Collaborator
i2h3
left a comment
i2h3
left a comment
There was a problem hiding this comment.
It looks fine to me, though I was thinking for a moment why in example contentType is not a constant either (breaking change). It is part of the initializer and has a default value of nil. I did not check call points but I assume those affected can just be extended with the initializer argument instead of mutating the property afterwards as I saw it. Then semantics and performance would benefit, as far as I know.
Out of scope for this pull request: At this point I ask myself why use reference semantics here at all because this would be fine as a plain struct. 🤔
…ible) Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
i2h3
force-pushed
the
feature/exposed-nkrequestoptions
branch
from
91623aa to
6c938be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed in NextcloudFileProviderKit to mock pagination behaviour of real server