Skip to content

Fix link shares sending incorrect request #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpivchev merged 1 commit into from
May 14, 2025
Merged

Fix link shares sending incorrect request #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Sources/NextcloudKit/NextcloudKit+Share.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ public extension NextcloudKit {
password: String? = nil,
expireDate: String? = nil,
permissions: Int = 1,
publicUpload: Bool = false,
publicUpload: Bool? = nil,
note: String? = nil,
label: String? = nil,
hideDownload: Bool,
Expand All @@ -365,24 +365,26 @@ public extension NextcloudKit {
var parameters = [
"permissions": String(permissions)
]
if let password = password {
if let password, !password.isEmpty {
parameters["password"] = password
}
if let expireDate = expireDate {
if let expireDate, !expireDate.isEmpty {
parameters["expireDate"] = expireDate
}
if let note = note {
if let note, !note.isEmpty {
parameters["note"] = note
}
if let label = label {
if let label, !label.isEmpty {
parameters["label"] = label
}
parameters["publicUpload"] = publicUpload ? "true" : "false"

if let publicUpload {
parameters["publicUpload"] = publicUpload ? "true" : "false"
}

parameters["hideDownload"] = hideDownload ? "true" : "false"
if let attributes = attributes {
parameters["attributes"] = attributes
} else {
parameters["attributes"] = "[]"
}

nkSession.sessionData.request(url, method: .put, parameters: parameters, encoding: URLEncoding.default, headers: headers, interceptor: NKInterceptor(nkCommonInstance: nkCommonInstance)).validate(statusCode: 200..<300).onURLSessionTaskCreation { task in
Expand Down