refactor: scope global state to major version of library#1492
Merged
Conversation
Problem ------- In the past when we did breaking changes on the API we could not ensure that all apps loaded are already migrated and so some of them were still using the old files integrations. Because the global scope was not versioned those apps registered e.g. invalid actions on the files app causing the files app to break. Solution -------- With the changes on this PR we versioning the global state of the files integrations. So we know that the files app will only load integrations that are using the same major version of the library so prevent breaking the whole app. Note: This is not a breaking change API wise as no exposed API has changed, but any app now needs to use at least this version of the library to properly integrate into the files app. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
type: enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
=======================================
Coverage 85.93% 85.93%
=======================================
Files 29 30 +1
Lines 661 661
Branches 193 192 -1
=======================================
Hits 568 568
Misses 81 81
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
changed the title
ShGKme
approved these changes
Feb 9, 2026
artonge
reviewed
Feb 13, 2026
| * | ||
| * @internal | ||
| */ | ||
| export const scopedGlobals = window._nc_files_scope.v4_0 as InternalGlobalScope |
Contributor
There was a problem hiding this comment.
Note: This is not a breaking change API wise as no exposed API has changed, but any app now needs to use at least this version of the library to properly integrate into the files app.
Could we at least fallback to _nc_files_scope? So that apps on v4.0.0-beta.X are still working
Suggested change
| export const scopedGlobals = window._nc_files_scope.v4_0 as InternalGlobalScope | |
| export const scopedGlobals = (window._nc_files_scope.v4_0 ?? window._nc_files_scope) as InternalGlobalScope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the past when we did breaking changes on the API we could not ensure that all apps loaded are already migrated and so some of them were still using the old files integrations.
Because the global scope was not versioned those apps registered e.g. invalid actions on the files app causing the files app to break.
Solution
With the changes on this PR we versioning the global state of the files integrations. So we know that the files app will only load integrations that are using the same major version of the library so prevent breaking the whole app.
Note: This is not a breaking change API wise as no exposed API has changed, but any app now needs to use at least this version of the library to properly integrate into the files app.